Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$this->smarty
in a module class is a very nice feature, you can assign variables and they are not global. Unfortunately$this->display
uses hacks to load overrides and cache. This PR introduce$this->fetch
which unleash the power of smarty. For a front module the best is described below.If your module is loading front template, do:
It will make theme override much more powerful! (read the doc for further information).
Wrapper.tpl
I also removed the wrapper tpl so modulefrontcontroller can call theme templates like
catalog/product.tpl
for instance.