New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc + update RequestSql class #6580

Merged
merged 1 commit into from Oct 7, 2016

Conversation

Projects
None yet
2 participants
@firstred
Contributor

firstred commented Oct 3, 2016

Questions Answers
Branch? develop
Description? Upgrading the PHPDoc comments of this class, using the latest PS standards and also applying the PS standards to some of the code. Also getting the Franglais out of the comments, getting rid of things the Symfony code sniffer nags about, etc. It might have some additional todo tags, depending on whether the code was comprehensible or not.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A

Warning: this PR also has a code cleanup. Please check this first before merging!

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 7, 2016

Contributor

Thank you @firstred !

Contributor

mickaelandrieu commented Oct 7, 2016

Thank you @firstred !

@mickaelandrieu mickaelandrieu merged commit 22f2f15 into PrestaShop:develop Oct 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment