New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Import: Prevent default category reset when already defined (1.7) #6650

Merged
merged 1 commit into from Oct 11, 2016

Conversation

Projects
None yet
2 participants
@firstred
Contributor

firstred commented Oct 11, 2016

Questions Answers
Branch? develop
Description? Redundant code causes the default category of a product to be reset, even when it already has a default category and the default is not given in the CSV.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-8501
How to test? Download the CSV from the ticket, change the product ID, link the columns (product ID, price) and check if the default category doesn't get reset anymore.

@firstred firstred changed the title from Prevent default category reset when already defined to Prevent default category reset when already defined (1.7) Oct 11, 2016

@firstred firstred changed the title from Prevent default category reset when already defined (1.7) to CSV Import: Prevent default category reset when already defined (1.7) Oct 11, 2016

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Oct 11, 2016

Contributor

Completely ok with this change.
Thanks @firstred !

Contributor

aleeks commented Oct 11, 2016

Completely ok with this change.
Thanks @firstred !

@aleeks aleeks merged commit ad45987 into PrestaShop:develop Oct 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment