New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module page small fixes #6666

Merged
merged 3 commits into from Oct 14, 2016

Conversation

Projects
None yet
6 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 12, 2016

Questions Answers
Branch? develop
Description? This PR add generic and default messages on the module page and fixes a tab of the read more panel
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket?
How to test? Make your addons authentication fail, install a module which returns false on install and look at the red more of the module "easy pack pro"
Show outdated Hide outdated src/PrestaShopBundle/Controller/Admin/AddonsController.php Outdated
@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Oct 14, 2016

Contributor

Hello @Quetzacoalt91
Can you rebase from develop your branch please? We had a problem with the travis's build!

Thank you!

Contributor

aleeks commented Oct 14, 2016

Hello @Quetzacoalt91
Can you rebase from develop your branch please? We had a problem with the travis's build!

Thank you!

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 14, 2016

Member

Rebased

Member

Quetzacoalt91 commented Oct 14, 2016

Rebased

@aleeks aleeks merged commit 877b49f into PrestaShop:develop Oct 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Oct 14, 2016

Contributor

Merged!
Thank you @Quetzacoalt91 !

Contributor

aleeks commented Oct 14, 2016

Merged!
Thank you @Quetzacoalt91 !

@BrunoJunior

This comment has been minimized.

Show comment
Hide comment
@BrunoJunior

BrunoJunior Oct 24, 2016

Contributor

I think there is a mistake in src/PrestaShopBundle/Controller/Admin/ModuleController.php
I made a module wich contains error during installation ($this->_errors[] = Tools::displayError($message);)
And when I install the module I have an error, but no message ...
I had to change line 526 :
$error = $moduleManager->getError($file_uploaded->getPathname());
to
$error = $moduleManager->getError($module_name);

Because the module manager use the name of the module and not the path to get errors ...

Contributor

BrunoJunior commented Oct 24, 2016

I think there is a mistake in src/PrestaShopBundle/Controller/Admin/ModuleController.php
I made a module wich contains error during installation ($this->_errors[] = Tools::displayError($message);)
And when I install the module I have an error, but no message ...
I had to change line 526 :
$error = $moduleManager->getError($file_uploaded->getPathname());
to
$error = $moduleManager->getError($module_name);

Because the module manager use the name of the module and not the path to get errors ...

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:module-page-debug-rework branch Oct 24, 2016

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 24, 2016

Member

Hello @BrunoJunior,

Nice catch. Would you mind to make a pull-request about this ?

Member

Quetzacoalt91 commented Oct 24, 2016

Hello @BrunoJunior,

Nice catch. Would you mind to make a pull-request about this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment