New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed errors on product form & duplicate menu #6678

Merged
merged 9 commits into from Oct 18, 2016

Conversation

Projects
None yet
5 participants
@aleeks
Contributor

aleeks commented Oct 13, 2016

Questions Answers
Branch? develop
Description? See down
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1634
How to test? Play with new product form! (make errors, test duplicate, deletion...)
  • Add error when create/update product with error, play with combinations!
  • Make error visible (top nav in red)
  • Remove duplicate action if your aren't in shop context
  • Fix delete product link, duplicate product link by removing redirect_url param....
Show outdated Hide outdated src/Adapter/Shop/Context.php Outdated
Show outdated Hide outdated src/PrestaShopBundle/Controller/Admin/ProductController.php Outdated
->getForm();
->add('step6', 'PrestaShopBundle\Form\Admin\Product\ProductOptions');
// Prepare combination form (fake but just to validate the form)

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Oct 18, 2016

Contributor

lulz

@mickaelandrieu

mickaelandrieu Oct 18, 2016

Contributor

lulz

This comment has been minimized.

@aleeks

aleeks Oct 18, 2016

Contributor

@mickaelandrieu Agree with you.. lulz :/

@aleeks

aleeks Oct 18, 2016

Contributor

@mickaelandrieu Agree with you.. lulz :/

@mickaelandrieu mickaelandrieu merged commit eefa8a3 into PrestaShop:develop Oct 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 18, 2016

Contributor

LGTM

Contributor

mickaelandrieu commented Oct 18, 2016

LGTM

@aleeks aleeks deleted the aleeks:product_error branch Oct 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment