New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided with theme translations and overrides #6690

Merged
merged 2 commits into from Oct 19, 2016

Conversation

Projects
None yet
4 participants
@thierrymarianne
Contributor

thierrymarianne commented Oct 14, 2016

Questions Answers
Branch? develop
Description? Theme translations lack messages from Shop* and Module* domains and should not be removed and replaced with extractions from templates.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1633
How to test? Translations should contain messages from default catalogues, Shop_, Module_ domains, parsed templates and theme translations directory in this order
@mickaelandrieu

Some things are totaly NOT required, let's discuss :)

SELECT `key`, `translation`, `domain`
FROM `'._DB_PREFIX_.'translation`
WHERE `id_lang` = '.$localeResult['id_lang']
);
;
$translations = Db::getInstance()->executeS($selectTranslationsQuery);

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Oct 17, 2016

Contributor

it's probably too late, but any chance to drop Db from any "Symfony" classes ? Maybe using DBAL ?

@mickaelandrieu

mickaelandrieu Oct 17, 2016

Contributor

it's probably too late, but any chance to drop Db from any "Symfony" classes ? Maybe using DBAL ?

This comment has been minimized.

@thierrymarianne

thierrymarianne Oct 17, 2016

Contributor

Instances of SqlTranslationLoader being also required in legacy Context, DBAL would not always be available to execute these queries.

@thierrymarianne

thierrymarianne Oct 17, 2016

Contributor

Instances of SqlTranslationLoader being also required in legacy Context, DBAL would not always be available to execute these queries.

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Oct 17, 2016

Contributor

hmmm ... :(

@mickaelandrieu

mickaelandrieu Oct 17, 2016

Contributor

hmmm ... :(

Show outdated Hide outdated src/PrestaShopBundle/Translation/Provider/FrontOfficeProvider.php Outdated
Show outdated Hide outdated src/PrestaShopBundle/Translation/Provider/ThemeProvider.php Outdated
Show outdated Hide outdated src/PrestaShopBundle/Translation/Provider/ThemeProvider.php Outdated
Show outdated Hide outdated src/PrestaShopBundle/Twig/TranslationsExtension.php Outdated
Show outdated Hide outdated src/PrestaShopBundle/Translation/Provider/ThemeProvider.php Outdated
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Oct 18, 2016

Contributor

@thierrymarianne tests dont pass :p

Contributor

mickaelandrieu commented Oct 18, 2016

@thierrymarianne tests dont pass :p

@thierrymarianne

This comment has been minimized.

Show comment
Hide comment
@thierrymarianne
Contributor

thierrymarianne commented Oct 19, 2016

@aleeks aleeks merged commit 7905ee6 into PrestaShop:develop Oct 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Oct 19, 2016

Contributor

Thank you @thierrymarianne !

Contributor

aleeks commented Oct 19, 2016

Thank you @thierrymarianne !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment