New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bulk actions on module page #6698

Merged
merged 2 commits into from Oct 17, 2016

Conversation

Projects
None yet
3 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 17, 2016

Questions Answers
Branch? develop
Description? The DOM has changed on the module page, breaking the bulk action system. This PR update the JS to follow the new structure.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? BOOM-1649
How to test? Use the bulk action in the "module page" > "Installed modules". Everything should work properly and a message should now appear when to try to launch a bulk action without any module selected.
@@ -335,6 +334,10 @@ var AdminModuleController = function() {
var body = $('body');
body.on('change', this.bulkActionDropDownSelector, function() {
if (0 === $(self.getBulkCheckboxesCheckedSelector()).length) {
$.growl.warning({message: "You need to select at least one module to use the bulk action."});

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Oct 17, 2016

Member

@AlexEven This is the typical messages currently not translated.

Another PR will follow for this task.

@Quetzacoalt91

Quetzacoalt91 Oct 17, 2016

Member

@AlexEven This is the typical messages currently not translated.

Another PR will follow for this task.

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Oct 17, 2016

Contributor

Thank you @Quetzacoalt91 !!!

Contributor

aleeks commented Oct 17, 2016

Thank you @Quetzacoalt91 !!!

@aleeks aleeks merged commit 8fd0a53 into PrestaShop:develop Oct 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aleeks aleeks removed their assignment Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment