New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add js strings of module page to translations #6700

Merged
merged 1 commit into from Oct 19, 2016

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 17, 2016

Questions Answers
Branch? develop
Description? Woups, many strings in JS were missing from the translated data. This PR add them.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Without the strings being translated, this gonna be difficult to tests them. But at least, they should still appear in English.
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 17, 2016

Member

Alexandra d'Even, I need your superpowers on this PR.

Member

Quetzacoalt91 commented Oct 17, 2016

Alexandra d'Even, I need your superpowers on this PR.

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 17, 2016

Member

PR #6698 merged. I rebased this one to make it easier to review.

Member

Quetzacoalt91 commented Oct 17, 2016

PR #6698 merged. I rebased this one to make it easier to review.

Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Module/manage.html.twig Outdated
Show outdated Hide outdated ...restaShopBundle/Resources/views/Admin/Module/Includes/menu_top.html.twig Outdated
Show outdated Hide outdated admin-dev/themes/default/js/bundle/module/module.js Outdated
Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Module/manage.html.twig Outdated
Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Module/manage.html.twig Outdated
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Oct 19, 2016

Member

Pull-request fixed and rebased, thx @AlexEven

Member

Quetzacoalt91 commented Oct 19, 2016

Pull-request fixed and rebased, thx @AlexEven

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Oct 19, 2016

Contributor

Thank you @Quetzacoalt91 I'm waiting for tests!

Contributor

aleeks commented Oct 19, 2016

Thank you @Quetzacoalt91 I'm waiting for tests!

@aleeks aleeks self-assigned this Oct 19, 2016

@aleeks aleeks merged commit fc60df1 into PrestaShop:develop Oct 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aleeks aleeks removed their assignment Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment