New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two new hooks actionAttributeCombinationSave/Delete #6718

Merged
merged 1 commit into from Oct 20, 2016

Conversation

Projects
None yet
2 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 19, 2016

Questions Answers
Branch? develop
Description? Unfortunately, the generic hooks action<object>AddAfter etc. are not called when we add product combinations. This PR add them.
Type? new feature
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? BOOM-1491
How to test? Implement the functions hookActionAttributeCombinationSave and/or hookActionAttributeCombinationDelete and check they are properly called when you generate product combinations.

Note: These hooks have not been added to the files 1.7.0.0.sql and hook.xml, which is expected for performance reasons. If a module is hooked on them, they should be called anyway.

@aleeks aleeks merged commit 429f2f2 into PrestaShop:develop Oct 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Oct 20, 2016

Contributor

Thank you @Quetzacoalt91

Contributor

aleeks commented Oct 20, 2016

Thank you @Quetzacoalt91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment