New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate edit translations view #6724

Merged
merged 1 commit into from Oct 20, 2016

Conversation

Projects
None yet
5 participants
@thierrymarianne
Contributor

thierrymarianne commented Oct 19, 2016

Questions Answers
Branch? develop
Description? Integrate edit translations view
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? Go to translation > international page
@aleeks

All your px value in rem() ?

.btn-expand,
.btn-reduce {
cursor: pointer;

This comment has been minimized.

@maximebiloe

maximebiloe Oct 19, 2016

Contributor

isn't any helper in the ui-kit to display buttons?

@maximebiloe

maximebiloe Oct 19, 2016

Contributor

isn't any helper in the ui-kit to display buttons?

This comment has been minimized.

@thierrymarianne

thierrymarianne Oct 20, 2016

Contributor

Those are specific, can't find them in the ui kit.

@thierrymarianne

thierrymarianne Oct 20, 2016

Contributor

Those are specific, can't find them in the ui kit.

Show outdated Hide outdated admin-dev/themes/new-theme/scss/pages/_translation_page.scss
Show outdated Hide outdated src/PrestaShopBundle/Controller/Admin/TranslationsController.php
Show outdated Hide outdated src/PrestaShopBundle/Controller/Admin/TranslationsController.php
Show outdated Hide outdated src/PrestaShopBundle/Controller/Admin/TranslationsController.php
Show outdated Hide outdated ...e/Resources/views/Admin/Translations/include/translations-tree.html.twig
Show outdated Hide outdated ...e/Resources/views/Admin/Translations/include/translations-tree.html.twig
Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Translations/list.html.twig
Show outdated Hide outdated ...e/Resources/views/Admin/Translations/include/translations-tree.html.twig
Show outdated Hide outdated ...e/Resources/views/Admin/Translations/include/translations-tree.html.twig
Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Translations/list.html.twig
Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Translations/list.html.twig
Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Translations/list.html.twig
Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Translations/list.html.twig
Show outdated Hide outdated src/PrestaShopBundle/Twig/TranslationsExtension.php
'<i class="material-icons visibility-on">&#xE8F4;</i>'.
'<i class="material-icons visibility-off hide">&#xE8F5;</i>'.
'<span class="btn-show-messages">' .
$this->translator->trans('Show messages', array(), 'Admin.International.Feature') .

This comment has been minimized.

@AlexEven

AlexEven Oct 20, 2016

Contributor

Where is the "Hide messages"?

@AlexEven

AlexEven Oct 20, 2016

Contributor

Where is the "Hide messages"?

This comment has been minimized.

@thierrymarianne

thierrymarianne Oct 20, 2016

Contributor

There is no Hide messages, moreover the Show messages button is not visible anymore even though it is used under the hood.

@thierrymarianne

thierrymarianne Oct 20, 2016

Contributor

There is no Hide messages, moreover the Show messages button is not visible anymore even though it is used under the hood.

This comment has been minimized.

@AlexEven

AlexEven Oct 20, 2016

Contributor

I meant this "Hide messages" - I couldn't see it, only "Show messages"

image

Thanks!

@AlexEven

AlexEven Oct 20, 2016

Contributor

I meant this "Hide messages" - I couldn't see it, only "Show messages"

image

Thanks!

This comment has been minimized.

@thierrymarianne

thierrymarianne Oct 20, 2016

Contributor

Ok, fixed.

@thierrymarianne

thierrymarianne Oct 20, 2016

Contributor

Ok, fixed.

@AlexEven

This comment has been minimized.

Show comment
Hide comment
@AlexEven

AlexEven Oct 20, 2016

Contributor

Thank you Thierry!
I have other comments ^^

1 - We have only two domains levels, I think we mentioned 3 levels.
Ex. In BO, Admin, today we have

Admin > AdvParametersFeature
Admin > AdvParametersHelp
Admin > AdvParametersNotifications

We should have

Admin > AdvParameters > Feature
Admin > AdvParameters > Help
Admin > AdvParameters > Notifications.

Like we had before I think.

2 - I have a weird display for Back Office > Modules > CheckPaymentAdmin - when I click twice on the category

2016-10-20_1127

3 - Why not using the full page?

2016-10-20_1138

I haven't tested if translations are still saved etc, but as it's not the purpose of the PR, we'll say it's ok :)
Thanks!

Contributor

AlexEven commented Oct 20, 2016

Thank you Thierry!
I have other comments ^^

1 - We have only two domains levels, I think we mentioned 3 levels.
Ex. In BO, Admin, today we have

Admin > AdvParametersFeature
Admin > AdvParametersHelp
Admin > AdvParametersNotifications

We should have

Admin > AdvParameters > Feature
Admin > AdvParameters > Help
Admin > AdvParameters > Notifications.

Like we had before I think.

2 - I have a weird display for Back Office > Modules > CheckPaymentAdmin - when I click twice on the category

2016-10-20_1127

3 - Why not using the full page?

2016-10-20_1138

I haven't tested if translations are still saved etc, but as it's not the purpose of the PR, we'll say it's ok :)
Thanks!

@thierrymarianne

This comment has been minimized.

Show comment
Hide comment
@thierrymarianne

thierrymarianne Oct 20, 2016

Contributor

Going from two levels to three levels can't be done with ease at this point.
2 has been fixed.

Contributor

thierrymarianne commented Oct 20, 2016

Going from two levels to three levels can't be done with ease at this point.
2 has been fixed.

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Oct 20, 2016

Contributor

Big thanks! @thierrymarianne

Contributor

aleeks commented Oct 20, 2016

Big thanks! @thierrymarianne

@aleeks aleeks merged commit a415d73 into PrestaShop:develop Oct 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment