New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native round instead of 2 forced decimals #6788

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
6 participants
@prestamodule
Contributor

prestamodule commented Oct 25, 2016

Questions Answers
Branch? 1.6.1.x
Description? Fix incorrect round when looking at order details
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Set decimals preferences to 6, order a product that is using 6 decimals to see the result. Without the fix, prices are looking like 12,340000€ / after: 12,345678€ into the order details
@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Oct 26, 2016

Contributor

Could this also be useful for the 'develop' branch?

Contributor

xBorderie commented Oct 26, 2016

Could this also be useful for the 'develop' branch?

@prestamodule

This comment has been minimized.

Show comment
Hide comment
@prestamodule

prestamodule Oct 27, 2016

Contributor

@xBorderie Yes, waiting for validation on this one to make the PR on 1.7 too.

Contributor

prestamodule commented Oct 27, 2016

@xBorderie Yes, waiting for validation on this one to make the PR on 1.7 too.

@hadjedjvincent

This comment has been minimized.

Show comment
Hide comment
@hadjedjvincent

hadjedjvincent Dec 22, 2016

Contributor

Hey guys,
2 months ago, we've asked validation for this PR.
Come on...

Contributor

hadjedjvincent commented Dec 22, 2016

Hey guys,
2 months ago, we've asked validation for this PR.
Come on...

@vincentbz vincentbz added this to the 1.6.1.13 milestone Mar 6, 2017

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Mar 6, 2017

Contributor

Hi guys,

Sorry for the late answer. We take it for 1.6.1.13 if it's still working, thanks ! :)

Contributor

vincentbz commented Mar 6, 2017

Hi guys,

Sorry for the late answer. We take it for 1.6.1.13 if it's still working, thanks ! :)

@vincentbz vincentbz removed their assignment Mar 6, 2017

@maximebiloe maximebiloe changed the title from BO: Use native round instead of 2 forced decimals, fix incorrect roun… to Use native round instead of 2 forced decimals Apr 6, 2017

@maximebiloe maximebiloe merged commit bff54d0 into PrestaShop:1.6.1.x Apr 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Apr 6, 2017

Contributor

Thank you @prestamodule

Contributor

maximebiloe commented Apr 6, 2017

Thank you @prestamodule

@aleeks aleeks removed their assignment May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment