Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translation keys in home slider #7104

Merged
merged 1 commit into from Dec 16, 2016

Conversation

@shakaran
Copy link
Contributor

commented Nov 28, 2016

Questions Answers
Branch? develop
Description? Add missing translation keys in home slider
Type? improvement
Category? FO
BC breaks? no
Deprecations? /no
Fixed ticket? -
How to test? Just load default theme with translations.

This allow to enable translations for the home slider in "classic" theme.

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Nov 28, 2016

Hello shakaran!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@shakaran shakaran changed the title Add missing translation keys in home slider FO: Add missing translation keys in home slider Nov 28, 2016

@aleeks aleeks removed the Translations label Nov 28, 2016

@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2016

@shakaran You changed the PR's title, not the commit's name.
As written by PrestonBot, you can't change the commit's name from the GitHub interface. You need to use Git from the command line.

@aleeks aleeks added the Translations label Nov 28, 2016

@xBorderie xBorderie added this to the 1.7.1.0 milestone Nov 28, 2016

@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2016

Moving this 1.7.1.0, since strings are frozen in 1.7.0.x.

FO: Add missing translation keys in home slider
This allow to enable translations for the home slider in "classic" theme.

@shakaran shakaran force-pushed the shakaran:develop branch from bc6420e to 477a2a4 Nov 28, 2016

@shakaran

This comment has been minimized.

Copy link
Contributor Author

commented Dec 2, 2016

Just an opinion (trying to be constructive). There are a lot PR very simple and basic and they take days or weeks to be merged and released. It is VERY important release early and release often, specially if you want a quickly adoption of PS 1.7. Also it encorauges to quick develop and new contributors interested.

If for a simple merge of a missing translation or other PR that are in queue takes weeks, the PS team is doing something wrong or indeed something that should be improved to reduce merge and release times.

More than 20 days after the official release, any minor 1.7.0.x or 1.7.x.x is released and considering that the bugs queue is almost growing exponentially, it should be taken with more urgency.

image

@xBorderie

This comment has been minimized.

Copy link
Contributor

commented Dec 2, 2016

Thanks @shakaran. We have very much aware of the need to a better PR flow, and are working with the available resources. We actually do daily meetings to talk about the recent Forge tickets and see which are the most urgent issues that have surfaced since the release of 1.7.0.0. We do our best to move quickly.

Your own PR here is indeed a simple one, but as I wrote, we can only merge it in 1.7.1.0, because our SemVer-like version won't let us merge it in a patch (1.7.0.x) version.

Thank you for your patience!

@aleeks aleeks removed the Translations label Dec 16, 2016

@aleeks aleeks removed this from the 1.7.1.0 milestone Dec 16, 2016

@aleeks

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2016

Thank you @shakaran !

@aleeks aleeks merged commit 360f99f into PrestaShop:develop Dec 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shakaran

This comment has been minimized.

Copy link
Contributor Author

commented Dec 16, 2016

Nice, @xBorderie @aleeks which remains for release finally 1.7.0.3? I see in github milestones more than 33 issues closed, that seems enough to make a release for "minor". It would be a nice pattern that prestashop release a minor each 1-2 weeks at least, that allows to users get soon the updates with minor bugs fixed. It is a pity that I have to my client waiting more than 1 month for just add a translation key officially. Indeed, she is not taking a good impression about use the new PrestaShop version because it is all in English (she is Spanish) and her consumers are mostly woman buying clothes and speaking spanish. So please, I have patience, but clients and consumers are different, they want all fixed quickly.

@Shudrum Shudrum changed the title FO: Add missing translation keys in home slider Add missing translation keys in home slider Feb 27, 2017

@eternoendless eternoendless added this to the 1.7.1.0 milestone May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.