New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that invoice siblings are related to the same order id. #7112

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
4 participants
@Shoprunners
Contributor

Shoprunners commented Nov 29, 2016

Questions Answers
Branch? "1.6.1.x"
Description? Bugfix makes sure, that only siblings of an payment are found which are related to the same oder
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? do several orders and change state
Peter Schaeffer
Update OrderInvoice.php
CO: Make sure that invoice siblings are related to the same order id.
@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Nov 29, 2016

Collaborator

Hi!

These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our guidelines:

`Update OrderInvoice.php

CO: Make sure that invoice siblings are related to the same order id.` is malformed or incomplete.

A valid commit name can be, for instance:

BO: Shows company in BO search if B2B is enabled

Would you mind to amend your commits' names?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

Thank you!

(note: this is an automated message, but answering it will reach a real human )

Collaborator

prestonBot commented Nov 29, 2016

Hi!

These(s) commit(s) name(s) seems to be incomplete or malformed, regarding our guidelines:

`Update OrderInvoice.php

CO: Make sure that invoice siblings are related to the same order id.` is malformed or incomplete.

A valid commit name can be, for instance:

BO: Shows company in BO search if B2B is enabled

Would you mind to amend your commits' names?

To do this, open a command line window and use git commit --amend for the commit's name. See GitHub's help page for more information.

Note: this must be done via the command line: you can't do this just by changing the title of the pull-request from the GitHub interface! :)

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Feb 10, 2017

Contributor

Make sense to me, thank you @Shopmonauten

Contributor

aleeks commented Feb 10, 2017

Make sense to me, thank you @Shopmonauten

@aleeks aleeks added this to the 1.6.1.13 milestone Feb 10, 2017

@aleeks aleeks changed the title from CO: Make sure that invoice siblings are related to the same order id. to Make sure that invoice siblings are related to the same order id. Feb 10, 2017

@maximebiloe maximebiloe merged commit 10204ea into PrestaShop:1.6.1.x Apr 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Apr 6, 2017

Contributor

Thank you @Shopmonauten

Contributor

maximebiloe commented Apr 6, 2017

Thank you @Shopmonauten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment