Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue on translations without params #7194

Merged
merged 1 commit into from Dec 20, 2016

Conversation

@Quetzacoalt91
Copy link
Member

commented Dec 9, 2016

Questions Answers
Branch? develop
Description? When we send to the translator a legacy string with a %s inside but without parameters, we got an htmlspecialchars in the translated value.
Type? bug fix
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1896
How to test? You should not have htmlspecialchars displayed on the theme/customer page

@Quetzacoalt91 Quetzacoalt91 force-pushed the Quetzacoalt91:BOOM-1896 branch from 8b0caa3 to 6a01022 Dec 9, 2016

@Quetzacoalt91 Quetzacoalt91 removed the WIP label Dec 9, 2016

@aleeks

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2016

Thank you @Quetzacoalt91

@aleeks aleeks merged commit b93796d into PrestaShop:develop Dec 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:BOOM-1896 branch Dec 28, 2016

@xBorderie xBorderie added this to the 1.7.0.4 milestone Jan 10, 2017

@prestonBot prestonBot referenced this pull request Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.