Update keyboard shortcut in product page for preview #7196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AntoineMille
commented
Dec 9, 2016
AntoineMille
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | BO: Update keyboard shortcut in product page for preview |
| Type? | bug fix |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | http://forge.prestashop.com/browse/BOOM-1755 |
| How to test? | Go to the product page in the BO and test CTRL+E |
prestonBot
added
the
Waiting for wording
aleeks
removed
the
Waiting for wording
|
Thank you @AntoineMille |
|
I don't understand. Why are we overriding default browser shortcuts like this? Browser shortcuts commonly bind to Ctrl+letter. Why don't we set these shortcuts to Alt+letter instead? This way we don't block the browser's native print, bookmark, etc. |
|
We are working on a better way to use shortcuts, in response to users' feedback and best practices |
|
way to break standards. I suggest if any key mappings are to be made they should be for the vision impaired following those standards |
Quetzacoalt91
changed the title
|
Hi, Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.