Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile Cart - Carriers Improperly integrated #7361

Merged
merged 1 commit into from Jan 24, 2017
Merged

Mobile Cart - Carriers Improperly integrated #7361

merged 1 commit into from Jan 24, 2017

Conversation

hibatallahAouadni
Copy link
Contributor

@hibatallahAouadni hibatallahAouadni commented Jan 18, 2017 •
edited by eternoendless

Questions Answers
Branch? develop
Description? fix the problem that appears only with the first proposed carrier (integration).
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-2179
How to test? order a product and choose a shipping method

  • iPad:
    ipad

  • iPhone6:
    iphone6

Important guidelines

This change is Reviewable

@prestonBot
Copy link
Collaborator

Hello hibatallahAouadni!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@hibatallahAouadni hibatallahAouadni changed the base branch from develop to 1.7.0.x January 18, 2017 08:47
@antoin-m
Copy link
Contributor

Hey @hibatallahAouadni , thank you for your contribution 😄

Could you please change the target branch to develop and add some screenshots of the results?

Thanks! 😃

@antoin-m antoin-m self-assigned this Jan 18, 2017
@hibatallahAouadni hibatallahAouadni changed the base branch from 1.7.0.x to develop January 18, 2017 13:51
@vincentbz vincentbz added the Waiting for QA Status: action required, waiting for test feedback label Jan 18, 2017
@hibatallahAouadni
Copy link
Contributor Author

hey @antoin-m done ;)

@hibatallahAouadni
Copy link
Contributor Author

Hello @maximebiloe
do you have to rebase this one too?

@maximebiloe
Copy link
Contributor

No, it's okay for this one

@antoin-m
Copy link
Contributor

Hey @hibatallahAouadni

Could you check why the tests are red?

@basma-yangui-prestashop basma-yangui-prestashop added the QA ✔️ Status: check done, code approved label Jan 23, 2017
@hibatallahAouadni
Copy link
Contributor Author

hey @antoin-m ,
the file travis.yml causes these problems and thanks to @basma-yangui-prestashop help I could find out, so I just rebase the branch against the develop branch and re-push it.

@antoin-m antoin-m merged commit 061fbe1 into PrestaShop:develop Jan 24, 2017
@antoin-m
Copy link
Contributor

Thank you @hibatallahAouadni ! 👍

@Shudrum Shudrum changed the title FO: Mobile Cart - Carriers Improperly integrated Mobile Cart - Carriers Improperly integrated Feb 27, 2017
@eternoendless eternoendless added this to the 1.7.6.0 milestone May 13, 2019
@eternoendless eternoendless modified the milestones: 1.7.6.0, 1.7.1.0 May 13, 2019
@prestonBot prestonBot added develop Branch Bug Type: Bug labels May 13, 2019
@ngodefroy ngodefroy removed the Waiting for QA Status: action required, waiting for test feedback label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@hibatallahAouadni @prestonBot @antoin-m @maximebiloe @eternoendless @vincentbz @basma-yangui-prestashop @ngodefroy