New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't double encode test email #7451

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
4 participants
@mcdado
Contributor

mcdado commented Feb 2, 2017

Questions Answers
Branch? 1.6.1.x
Description? Test emails were being double encoded when sent. This is also because in the test sending function they're sent as plain text and not as HTML. Example for italian: Questo è un messaggio di test, il tuo server è adesso disponibile ad inviare le email.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Set the translation of the test email message to something which includes accented characters and send a test email.
@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Feb 7, 2017

Contributor

Thanks @mcdado !
Seems to make sense. What do you think @maximebiloe ?

Contributor

xBorderie commented Feb 7, 2017

Thanks @mcdado !
Seems to make sense. What do you think @maximebiloe ?

@maximebiloe maximebiloe self-assigned this Feb 7, 2017

@mcdado

This comment has been minimized.

Show comment
Hide comment
@mcdado

mcdado Mar 14, 2017

Contributor

Rebased on top of 1.6.1.x.

Contributor

mcdado commented Mar 14, 2017

Rebased on top of 1.6.1.x.

@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Mar 14, 2017

Contributor

Thank you for this, David!

Contributor

xBorderie commented Mar 14, 2017

Thank you for this, David!

@vincentbz vincentbz added this to the 1.6.1.13 milestone Mar 15, 2017

@maximebiloe maximebiloe merged commit f5833df into PrestaShop:1.6.1.x Apr 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Apr 6, 2017

Contributor

Thank you @mcdado

Contributor

maximebiloe commented Apr 6, 2017

Thank you @mcdado

@mcdado mcdado deleted the mcdado:test-email-double-encode branch Apr 6, 2017

@maximebiloe maximebiloe removed their assignment Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment