Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback on HelperList should have highest priority #7552

Merged
merged 1 commit into from Feb 15, 2017

Conversation

kpodemski
Copy link
Contributor

Questions Answers
Branch? develop
Description? Callback result in HelperList should have highest priority to prevents error like this one
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? check before/after images below

BEFORE:
image

AFTER:
image

@kpodemski
Copy link
Contributor Author

btw. i'll cherry pick this into 1.6 after merge here

@Shudrum
Copy link
Contributor

Shudrum commented Feb 15, 2017

Hey!

Thank you @kpodemski! Instant merge!

👍

@Shudrum Shudrum merged commit cd43d21 into PrestaShop:develop Feb 15, 2017
@aleeks
Copy link
Contributor

aleeks commented Feb 15, 2017

Strange, to me, it was working on develop before this..

Real problem was here: https://github.com/PrestaShop/PrestaShop/pull/7379/files

@kpodemski
Copy link
Contributor Author

@aleeks it needs to be type=bool, that was not a problem, with your change you cannot filter on this field i don't know if you've noticed :)

@aleeks
Copy link
Contributor

aleeks commented Feb 15, 2017

OMG, yes!
#7559

Thank you!!!

@eternoendless eternoendless added this to the 1.7.1.0 milestone May 13, 2019
@kpodemski kpodemski deleted the fix-bool-callback branch July 4, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants