New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getBaseLink() should be public #7560

Merged
merged 1 commit into from Jun 22, 2017

Conversation

Projects
None yet
5 participants
@iNem0o
Contributor

iNem0o commented Feb 15, 2017

Questions Answers
Branch? 1.6.1.x
Description? this method should be public because its usefull for ex in modules (already fixed in 1.7)
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? use $link->getBaseLink() from outside of Link class

@iNem0o iNem0o changed the title from [CO] getBaseLink() should be public to CO: getBaseLink() should be public Feb 15, 2017

@aleeks aleeks changed the title from CO: getBaseLink() should be public to getBaseLink() should be public May 9, 2017

@aleeks aleeks added this to the 1.6.1.15 milestone May 9, 2017

@maximebiloe maximebiloe merged commit be59cba into PrestaShop:1.6.1.x Jun 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Jun 22, 2017

Contributor

Thank you @iNem0o

Contributor

maximebiloe commented Jun 22, 2017

Thank you @iNem0o

@dariusakafest

This comment has been minimized.

Show comment
Hide comment
@dariusakafest

dariusakafest Jul 18, 2017

Contributor

@iNem0o , I encountered such a problem that I overload the Link class and it has the getBaseLink method, before that it was protected, and now the public. PHP produces a Fatal error.
How can I add two Link classes to the override of module, one will have a protection method for versions 1.6.1.4 and lower. And public metod for version 1.6.1.5?

Contributor

dariusakafest commented Jul 18, 2017

@iNem0o , I encountered such a problem that I overload the Link class and it has the getBaseLink method, before that it was protected, and now the public. PHP produces a Fatal error.
How can I add two Link classes to the override of module, one will have a protection method for versions 1.6.1.4 and lower. And public metod for version 1.6.1.5?

@iNem0o

This comment has been minimized.

Show comment
Hide comment
@iNem0o

iNem0o Jul 18, 2017

Contributor

Hi @dariusakafest
I tried using the following code and it doesn't seems to trigger an error

https://gist.github.com/iNem0o/be380bdbac7925530533b1ff84e4699a

tested on 5.3 - 5.4 - 5.5 - 5.6 - 7.0 - 7.1 using an online interpreter

Contributor

iNem0o commented Jul 18, 2017

Hi @dariusakafest
I tried using the following code and it doesn't seems to trigger an error

https://gist.github.com/iNem0o/be380bdbac7925530533b1ff84e4699a

tested on 5.3 - 5.4 - 5.5 - 5.6 - 7.0 - 7.1 using an online interpreter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment