Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix ecotax rounded twice #7581
Cherry-pick of #7448
If taxes are turned on on ecotax, ecotax used to be rounded twice. Once after fetching the DB value and the second time after multiplying it with the tax rate. Now it's only rounded after taxes. Example: If you want an ecotax of 10 (with 21% VAT), the ecotax in database is 8.264463 (because 8.264463 * 1.21 = 10). But without this fix, PrestaShop would round the ecotax DB value to 8.26, then multiply it 8.26 * 1.21 = 9.99 (wrong, one cent too little)
This was referenced
Sep 5, 2017
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.