New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install language #7672

Merged
merged 2 commits into from Apr 5, 2017

Conversation

Projects
None yet
5 participants
@aleeks
Contributor

aleeks commented Mar 15, 2017

Questions Answers
Branch? 1.6.1.x
Description? Fix install language
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? check admin.php, errors.php, etc file on translations after installing
@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Mar 15, 2017

Contributor

futurama

Contributor

vincentbz commented Mar 15, 2017

futurama

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Mar 15, 2017

Contributor

Dirty fix for the moment because it's working during the modules update.. and not because we want 😄

ping @kpodemski

Contributor

aleeks commented Mar 15, 2017

Dirty fix for the moment because it's working during the modules update.. and not because we want 😄

ping @kpodemski

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Mar 15, 2017

Contributor

Too dirty to be tested ? 😇

Contributor

vincentbz commented Mar 15, 2017

Too dirty to be tested ? 😇

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Mar 16, 2017

Contributor

UPGRADEEEEEEEEED GOGOGO

Contributor

aleeks commented Mar 16, 2017

UPGRADEEEEEEEEED GOGOGO

@aleeks aleeks added this to the 1.6.1.13 milestone Mar 16, 2017

@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Mar 16, 2017

Contributor

Yes, it's working @vincentbz @aleeks

Good job 👍

Contributor

kpodemski commented Mar 16, 2017

Yes, it's working @vincentbz @aleeks

Good job 👍

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Mar 16, 2017

Contributor

Hell yeah !

Contributor

vincentbz commented Mar 16, 2017

Hell yeah !

@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Apr 5, 2017

Contributor

Thank you @aleeks & @kpodemski for the help

Contributor

maximebiloe commented Apr 5, 2017

Thank you @aleeks & @kpodemski for the help

@maximebiloe maximebiloe merged commit f668e1c into PrestaShop:1.6.1.x Apr 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maximebiloe maximebiloe deleted the aleeks:fix_install_lang branch Apr 5, 2017

@@ -960,7 +960,17 @@ public static function downloadAndInstallLanguagePack($iso, $version = null, $pa
$files_list = $other_files;
}
if (!$gz->extractList(AdminTranslationsController::filesListToPaths($files_list), _PS_TRANSLATIONS_DIR_.'../')) {
// don't know why, but it's needed & doesn't work otherwise

This comment has been minimized.

@hibatallahAouadni

hibatallahAouadni Jul 11, 2017

Contributor

@aleeks the translations_extract is needed and it works, so which part it doesn't work?

@hibatallahAouadni

hibatallahAouadni Jul 11, 2017

Contributor

@aleeks the translations_extract is needed and it works, so which part it doesn't work?

This comment has been minimized.

@aleeks

aleeks Jul 11, 2017

Contributor

Maybe in some case, it doesn't work.. I don't know why we did it like that.

@aleeks

aleeks Jul 11, 2017

Contributor

Maybe in some case, it doesn't work.. I don't know why we did it like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment