New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 255 char to company field in Adress #7692

Merged
merged 2 commits into from Apr 5, 2017

Conversation

Projects
None yet
5 participants
@fatmaBouchekoua
Contributor

fatmaBouchekoua commented Mar 22, 2017

Questions Answers
Branch? 1.6.1.x
Description? Company field in Address doesn't allow more than 64 char.
Type? improvement
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-8949
How to test? Reinstall your shop and try to add new Address with a long name of company

@fatmaBouchekoua fatmaBouchekoua added this to the 1.6.1.13 milestone Mar 22, 2017

@aleeks

Hello @fatmaBouchekoua
Create a file upgrade 1.6.1.13.sql please & make your request !

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Mar 22, 2017

Contributor

Done. Thanks !

Contributor

fatmaBouchekoua commented Mar 22, 2017

Done. Thanks !

@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Mar 22, 2017

Contributor

I'm ok with this change but are we sure that it can be part of path version? @xBorderie

Contributor

kpodemski commented Mar 22, 2017

I'm ok with this change but are we sure that it can be part of path version? @xBorderie

@aleeks

aleeks approved these changes Mar 23, 2017

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Mar 23, 2017

Contributor

When it will be merged, please, :

  • add your sql script to 1.7.0.x
  • change db structure on develop branch
Contributor

aleeks commented Mar 23, 2017

When it will be merged, please, :

  • add your sql script to 1.7.0.x
  • change db structure on develop branch
@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Apr 5, 2017

Contributor

@kpodemski we know it shouldn't be embedded in a patch version, but it's a really minor change, so we'll make an exception for this one.

Thank you @fatmaBouchekoua

Contributor

maximebiloe commented Apr 5, 2017

@kpodemski we know it shouldn't be embedded in a patch version, but it's a really minor change, so we'll make an exception for this one.

Thank you @fatmaBouchekoua

@maximebiloe maximebiloe merged commit c4afc48 into PrestaShop:1.6.1.x Apr 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maximebiloe maximebiloe deleted the fatmaBouchekoua:PSCSX-8949 branch Apr 5, 2017

@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker May 4, 2017

Contributor

I want to apply this fix for my website without upgrading Prestashop to newest version. Do I just run this code in SQL on my database?

SET NAMES 'utf8';

ALTER TABLE `PREFIX_address` CHANGE `company` `company` VARCHAR(255) DEFAULT NULL;

and replace code in classes/Address.php?

I am not familiar with SQL, therefor I ask, so I don't mess something up.

Contributor

Mreker commented May 4, 2017

I want to apply this fix for my website without upgrading Prestashop to newest version. Do I just run this code in SQL on my database?

SET NAMES 'utf8';

ALTER TABLE `PREFIX_address` CHANGE `company` `company` VARCHAR(255) DEFAULT NULL;

and replace code in classes/Address.php?

I am not familiar with SQL, therefor I ask, so I don't mess something up.

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks May 5, 2017

Contributor

Hello @Mreker
Yes, you have to, just replace PREFIX_ with your prefix database :)
It should be work

Regards

Contributor

aleeks commented May 5, 2017

Hello @Mreker
Yes, you have to, just replace PREFIX_ with your prefix database :)
It should be work

Regards

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks May 5, 2017

Contributor

@fatmaBouchekoua

Can you please :

  • add your sql script to develop branc
  • change db structure on develop branch

Edit: Wait, let me do this

Double edit: already done here: #7743

Contributor

aleeks commented May 5, 2017

@fatmaBouchekoua

Can you please :

  • add your sql script to develop branc
  • change db structure on develop branch

Edit: Wait, let me do this

Double edit: already done here: #7743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment