New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix country change in checkout form #7710

Merged
merged 4 commits into from Apr 5, 2017

Conversation

Projects
None yet
7 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Mar 28, 2017

Questions Answers
Branch? 1.7.1.x
Description? This PR use #7595 as base. It will fix the bug after a country change in checkout form, and an issue with the cancel button
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-2227
How to test? Follow steps in BOOM-2227

@Quetzacoalt91 Quetzacoalt91 changed the title from Martinfojtik patch 38 to Fix country change in checkout form (updated) Mar 28, 2017

@Quetzacoalt91 Quetzacoalt91 changed the title from Fix country change in checkout form (updated) to Fix country change in checkout form (Suggestion) Mar 28, 2017

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Mar 28, 2017

Contributor

And it works^^

bradpitt

Contributor

vincentbz commented Mar 28, 2017

And it works^^

bradpitt

@vincentbz vincentbz added the QA ✔️ label Mar 28, 2017

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Mar 28, 2017

Contributor

By the way, is it possible to have it on the 1.7.1.x branch please ? So that it can be merged in the 1.7.1.1 version . Thanks !

Contributor

vincentbz commented Mar 28, 2017

By the way, is it possible to have it on the 1.7.1.x branch please ? So that it can be merged in the 1.7.1.1 version . Thanks !

@Quetzacoalt91 Quetzacoalt91 changed the base branch from develop to 1.7.1.x Mar 28, 2017

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:martinfojtik-patch-38 branch Mar 28, 2017

@Quetzacoalt91 Quetzacoalt91 restored the Quetzacoalt91:martinfojtik-patch-38 branch Mar 28, 2017

@Quetzacoalt91 Quetzacoalt91 reopened this Mar 28, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Mar 28, 2017

Member

PR moved to the branch 1.7.1.x

Member

Quetzacoalt91 commented Mar 28, 2017

PR moved to the branch 1.7.1.x

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Mar 29, 2017

Contributor

Danke !

Contributor

vincentbz commented Mar 29, 2017

Danke !

@martinfojtik

This comment has been minimized.

Show comment
Hide comment
@martinfojtik

martinfojtik Mar 30, 2017

Contributor

Hi @Quetzacoalt91, good job.

Contributor

martinfojtik commented Mar 30, 2017

Hi @Quetzacoalt91, good job.

@vincentbz vincentbz added this to the 1.7.1.1 milestone Apr 5, 2017

@maximebiloe maximebiloe changed the title from Fix country change in checkout form (Suggestion) to Fix country change in checkout form Apr 5, 2017

@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Apr 5, 2017

Contributor

Thank you @Quetzacoalt91

Contributor

maximebiloe commented Apr 5, 2017

Thank you @Quetzacoalt91

@maximebiloe maximebiloe merged commit f8f3a11 into PrestaShop:1.7.1.x Apr 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maximebiloe maximebiloe deleted the Quetzacoalt91:martinfojtik-patch-38 branch Apr 5, 2017

@kingreym

This comment has been minimized.

Show comment
Hide comment
@kingreym

kingreym May 24, 2017

Not working when upgrading to 1.7.1.1, works only when installing fresh PS.
Where can I find that ajax call so i can modify it by my own?

kingreym commented May 24, 2017

Not working when upgrading to 1.7.1.1, works only when installing fresh PS.
Where can I find that ajax call so i can modify it by my own?

@kingreym

This comment has been minimized.

Show comment
Hide comment
@kingreym

kingreym May 24, 2017

Never ever again gonna use prestashop. Trash of trashes.

kingreym commented May 24, 2017

Never ever again gonna use prestashop. Trash of trashes.

@kamilko

This comment has been minimized.

Show comment
Hide comment
@kamilko

kamilko Jun 9, 2017

@kingreym You probably using not default theme or you didn't update correctly. I had similar issue but it's resolvable if you modify manually own theme as you can find in here pressing: Files changed (last two tpl files).

kamilko commented Jun 9, 2017

@kingreym You probably using not default theme or you didn't update correctly. I had similar issue but it's resolvable if you modify manually own theme as you can find in here pressing: Files changed (last two tpl files).

@kingreym

This comment has been minimized.

Show comment
Hide comment
@kingreym

kingreym Jun 13, 2017

@kamilko thx for your response, but I'm done with open-sources.

kingreym commented Jun 13, 2017

@kamilko thx for your response, but I'm done with open-sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment