New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when updating quantity wanted input #7781

Merged
merged 2 commits into from Sep 18, 2017

Conversation

Projects
None yet
9 participants
@fatmaBouchekoua
Contributor

fatmaBouchekoua commented Apr 13, 2017

Questions Answers
Branch? develop
Description? When ordering a number of item greater than quantity without using arrows , there is no error message and we can still push the Add to card button.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-1965
How to test? Go to product detail page and try to add to cart a number of item grater than quantity without using arrows.
@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Apr 13, 2017

Contributor

You're introducing FlexBox syntax, which only works in IE 10+, and as far as I know Classic should be IE 9+. What do you think, @maximebiloe ?

Contributor

xBorderie commented Apr 13, 2017

You're introducing FlexBox syntax, which only works in IE 10+, and as far as I know Classic should be IE 9+. What do you think, @maximebiloe ?

@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Apr 13, 2017

Contributor

We already use some FlexBox in Classic.
We're using flexibility.js, a polyfill to make them work with IE 9, so it's not a problem in my opinion.

Contributor

maximebiloe commented Apr 13, 2017

We already use some FlexBox in Classic.
We're using flexibility.js, a polyfill to make them work with IE 9, so it's not a problem in my opinion.

@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Apr 13, 2017

Contributor

Alright, cool! :)

Contributor

xBorderie commented Apr 13, 2017

Alright, cool! :)

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Jun 13, 2017

Contributor

Hi,

Is this PR still relevant as this one is merged ?
#7992

Thanks !

Contributor

vincentbz commented Jun 13, 2017

Hi,

Is this PR still relevant as this one is merged ?
#7992

Thanks !

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Jun 13, 2017

Contributor

Hello @vincentbz ,
I've rebased it and test it, it works fine.
Can you retest please?

Thanks !

Contributor

fatmaBouchekoua commented Jun 13, 2017

Hello @vincentbz ,
I've rebased it and test it, it works fine.
Can you retest please?

Thanks !

@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Jun 19, 2017

Contributor

Seems like it needs to be rebased again :/

Contributor

xBorderie commented Jun 19, 2017

Seems like it needs to be rebased again :/

@vincentbz vincentbz added this to the 1.7.2.0 milestone Jun 19, 2017

Show outdated Hide outdated themes/_core/js/cart.js
Show outdated Hide outdated themes/_core/js/cart.js
Show outdated Hide outdated themes/_core/js/cart.js
Show outdated Hide outdated themes/_core/js/cart.js
Show outdated Hide outdated themes/_core/js/cart.js
Show outdated Hide outdated themes/classic/templates/catalog/_partials/product-details.tpl
Show outdated Hide outdated themes/_core/js/cart.js

@eternoendless eternoendless added the Bug label Jun 23, 2017

@maximebiloe maximebiloe modified the milestones: 1.7.2.0, 1.7.2.1 Jun 26, 2017

Show outdated Hide outdated themes/classic/_dev/css/components/products.scss
Show outdated Hide outdated themes/_core/js/cart.js
Show outdated Hide outdated themes/_core/js/cart.js
Show outdated Hide outdated themes/_core/js/cart.js
Show outdated Hide outdated themes/classic/_dev/js/product.js
Show outdated Hide outdated themes/classic/templates/catalog/_partials/product-details.tpl

@maximebiloe maximebiloe changed the base branch from develop to 1.7.2.x Jul 21, 2017

@aleeks aleeks removed this from the 1.7.2.1 milestone Jul 24, 2017

@vincentbz vincentbz added this to the 1.7.3.0 milestone Sep 4, 2017

Comments have been adressed

@vincentbz vincentbz removed this from the 1.7.3.0 milestone Sep 14, 2017

@vincentbz vincentbz added this to the 1.7.2.3 milestone Sep 14, 2017

@toutantic toutantic merged commit bb93575 into PrestaShop:1.7.2.x Sep 18, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment