Remove all bourbon deprecations #7792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maximebiloe
commented
Apr 14, 2017
maximebiloe
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Switch to webpack 2 and remove all bourbon deprecations |
| Type? | bug fix |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| How to test? |
| 'sprintf-js/src/sprintf.js', | ||
| './js/theme.js' | ||
| ], | ||
| let config = { |
There was a problem hiding this comment.
Error thrown on this line:
> new-theme@1.0.0 postinstall /home/thomas/Documents/github/PrestaShop/admin-dev/themes/new-theme
> webpack --progress
/home/thomas/Documents/github/PrestaShop/admin-dev/themes/new-theme/webpack.config.js:5
let config = {
^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:374:25)
at Object.Module._extensions..js (module.js:417:10)
at Module.load (module.js:344:32)
at Function.Module._load (module.js:301:12)
at Module.require (module.js:354:17)
at require (internal/module.js:12:17)
at requireConfig (/home/thomas/Documents/github/PrestaShop/admin-dev/themes/new-theme/node_modules/webpack/bin/convert-argv.js:96:18)
at /home/thomas/Documents/github/PrestaShop/admin-dev/themes/new-theme/node_modules/webpack/bin/convert-argv.js:109:17
at Array.forEach (native)
There was a problem hiding this comment.
Adding
"use strict";
at the beginning of the file fixes the issue.
There was a problem hiding this comment.
It seems that you're using an old version of Node. It should be automatically detected, so as seen with @Shudrum no need to precise it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.