New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the conversion_rate in the order_payment table #7793

Merged
merged 1 commit into from Jun 23, 2017

Conversation

Projects
None yet
4 participants
@hibatallahAouadni
Contributor

hibatallahAouadni commented Apr 17, 2017

Questions Answers
Branch? 1.6.1.x
Description? The table that contains payments related to orders (ps_order_payment) contains a field named conversion_rate. This field is always set to 1.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-8983
How to test? made an order with another currency (not the default one), then update its status to "payment accepted", check the "order_payment" table, you will see the "conversion_rate" is correctly saved.
@hibatallahAouadni

This comment has been minimized.

Show comment
Hide comment
Contributor

hibatallahAouadni commented May 26, 2017

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks May 29, 2017

Contributor

Should we cherry-picked on develop ?

Contributor

aleeks commented May 29, 2017

Should we cherry-picked on develop ?

@eternoendless eternoendless added the Bug label Jun 23, 2017

@eternoendless

Code looks good

@hibatallahAouadni

This comment has been minimized.

Show comment
Hide comment
@hibatallahAouadni

hibatallahAouadni Jun 23, 2017

Contributor

@maximebiloe should we add it to 1.6.1.15?

Contributor

hibatallahAouadni commented Jun 23, 2017

@maximebiloe should we add it to 1.6.1.15?

@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Jun 23, 2017

Contributor

Yes, we'll take it

Contributor

maximebiloe commented Jun 23, 2017

Yes, we'll take it

@maximebiloe maximebiloe added this to the 1.6.1.15 milestone Jun 23, 2017

@maximebiloe maximebiloe merged commit 8a61f81 into PrestaShop:1.6.1.x Jun 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Jun 23, 2017

Contributor

Cherry-picked here: #8044

Contributor

maximebiloe commented Jun 23, 2017

Cherry-picked here: #8044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment