Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import theme while module use non registered hook in DB #7842

Merged
merged 1 commit into from Jul 21, 2017

Conversation

@prestamodule
Copy link
Contributor

prestamodule commented Apr 29, 2017

Questions Answers
Branch? 1.6.1.x
Description? While you want to use a theme that use a module with a custom hook not already registered, the Hook ID is equal to zero and it can thrown a SQL exception cause it's already in table hook_module
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? Just try to use/install theme with custom module having hook not already registered.
@vincentbz vincentbz added this to the 1.6.1.16 milestone Jun 26, 2017
@maximebiloe maximebiloe merged commit 2482eab into PrestaShop:1.6.1.x Jul 21, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maximebiloe

This comment has been minimized.

Copy link
Contributor

maximebiloe commented Jul 21, 2017

Thanks @prestamodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.