New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Deutsch instead of Deutsch CH for Switzerland #8000

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
5 participants
@maximebiloe
Contributor

maximebiloe commented Jun 13, 2017

Questions Answers
Branch? develop
Description? Seen with @AlexEven, we will install Deutsch instead of Deutsch CH for Switzerland. I've also made the modifications on the translations files.
Type? improvement
Category? LO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? In order to test, you need to make some changes. As the list of available languages is fetch from a remote server according to PrestaShop Version, you need to edit config/autoload.php and install-dev/install_version.php and set it 1.7.2.0. Then, check that when you install the Switzerland localization pack you have the french, german and italian languages. Make sure to set Download pack data to no as this PR is not merged yet. Also, when you go to International > Translations you shouldn't see Deutsch (German) anymore.

@maximebiloe maximebiloe added this to the 1.7.2.0 milestone Jun 13, 2017

@AlexEven

This comment has been minimized.

Show comment
Hide comment
@AlexEven

AlexEven Jun 13, 2017

Contributor

Note: we're removing DE-CH as it brings no value to the merchants and confuses them. It's a mere copy of the German language, with no specificities to Switzerland.
We'll add it anew when it is different from the German project (= starting from scratch for DE-CH on Crowdin).
Thanks!

Contributor

AlexEven commented Jun 13, 2017

Note: we're removing DE-CH as it brings no value to the merchants and confuses them. It's a mere copy of the German language, with no specificities to Switzerland.
We'll add it anew when it is different from the German project (= starting from scratch for DE-CH on Crowdin).
Thanks!

@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Jun 19, 2017

Contributor

8000th PR! \o/

Contributor

xBorderie commented Jun 19, 2017

8000th PR! \o/

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Jun 20, 2017

Contributor

Thank you @maximebiloe

Contributor

aleeks commented Jun 20, 2017

Thank you @maximebiloe

@aleeks aleeks merged commit 2f8cd69 into PrestaShop:develop Jun 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aleeks aleeks deleted the maximebiloe:remove-deutsch-ch branch Jun 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment