New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding pack in itself #8015

Merged
merged 1 commit into from Jun 22, 2017

Conversation

Projects
None yet
4 participants
@hibatallahAouadni
Contributor

hibatallahAouadni commented Jun 15, 2017

Questions Answers
Branch? 1.6.1.x
Description? When creating a product pack (by editing an exisiting standard product and setting it as a pack) Prestashop is allowing to insert the same ID product in the product pack list.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-8516
How to test? Create a standard product -> Edit the product and mark it as a pack of products -> Add a product to the pack and choose the same product -> Save -> Try to open that product from front office with a profiler.

@maximebiloe maximebiloe added this to the 1.6.1.15 milestone Jun 20, 2017

@marionf marionf added QA ✔️ and removed waiting for QA labels Jun 21, 2017

@maximebiloe maximebiloe merged commit 2aaae7b into PrestaShop:1.6.1.x Jun 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maximebiloe

This comment has been minimized.

Show comment
Hide comment
Contributor

maximebiloe commented Jun 22, 2017

Thanks @hibatallahAouadni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment