New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save before generate combinations #8057

Merged
merged 2 commits into from Aug 23, 2017

Conversation

Projects
None yet
6 participants
@fatmaBouchekoua
Contributor

fatmaBouchekoua commented Jun 28, 2017

Questions Answers
Branch? 1.7.2.x
Description? If you generate combinations without saving before, the data can be lost. This PR launch the save button before combination generation.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-3284
How to test? Create a product, don't put a name, generate combinations, put price and quantities. Refresh, everything has disappeared except the combinations

@vincentbz vincentbz added this to the 1.7.2.1 milestone Jul 11, 2017

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Jul 11, 2017

Contributor

Hi @fatmaBouchekoua ,

Could you move this PR to 1.7.2.x branch please ? So that it can be taken in 1.7.2.1

Thanks !

Contributor

vincentbz commented Jul 11, 2017

Hi @fatmaBouchekoua ,

Could you move this PR to 1.7.2.x branch please ? So that it can be taken in 1.7.2.1

Thanks !

@marionf marionf added QA ✔️ and removed waiting for QA labels Jul 11, 2017

@maximebiloe maximebiloe changed the base branch from develop to 1.7.2.x Jul 21, 2017

@eternoendless eternoendless added this to the 1.7.2.2 milestone Aug 10, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 10, 2017

Member

Are all the commits expected in this PR ? It seems a rebase went wrong.

Member

Quetzacoalt91 commented Aug 10, 2017

Are all the commits expected in this PR ? It seems a rebase went wrong.

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Aug 10, 2017

Member

You mean this one? 52f4e80

It does look unrelated but I don't think it hurts.

Member

eternoendless commented Aug 10, 2017

You mean this one? 52f4e80

It does look unrelated but I don't think it hurts.

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Aug 10, 2017

Member

@fatmaBouchekoua Could you please confirm if that commit belongs to another PR? If that's the case, please rebase it out from this one.

Member

eternoendless commented Aug 10, 2017

@fatmaBouchekoua Could you please confirm if that commit belongs to another PR? If that's the case, please rebase it out from this one.

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Aug 10, 2017

Contributor

Hello @eternoendless & @Quetzacoalt91 ,
I've removed this commit from 3 other PRs (I don't know how it got into my PRs).
I will remove it

Contributor

fatmaBouchekoua commented Aug 10, 2017

Hello @eternoendless & @Quetzacoalt91 ,
I've removed this commit from 3 other PRs (I don't know how it got into my PRs).
I will remove it

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Aug 23, 2017

Thank you @fatmaBouchekoua

@eternoendless eternoendless merged commit 9512598 into PrestaShop:1.7.2.x Aug 23, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment