Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Finder from depency injection #8124

Merged
merged 1 commit into from Jul 12, 2017
Merged

Remove Finder from depency injection #8124

merged 1 commit into from Jul 12, 2017

Conversation

Quetzacoalt91
Copy link
Member

Questions Answers
Branch? 1.7.2.x
Description? Reusing the same Finder instance several times brought unexpected behavior during many searches. We now recreate it every time we need it instead of calling it from the service container.
Type? bug fix
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Theme import seems to bug in some case when several modules must be enabled. If needed, see with @rGaillard for more details.

@Quetzacoalt91 Quetzacoalt91 changed the title CO: Remove Finder from depency injection Remove Finder from depency injection Jul 11, 2017
@maximebiloe maximebiloe merged commit 98f9180 into PrestaShop:1.7.2.x Jul 12, 2017
@maximebiloe
Copy link
Contributor

Thank you @Quetzacoalt91

@maximebiloe maximebiloe deleted the remove-finder-as-dependancy branch July 12, 2017 09:28
@aleeks aleeks added this to the 1.7.2.0 milestone Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximebiloe maximebiloe maximebiloe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Quetzacoalt91 @maximebiloe @aleeks