New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing product limit/offset when ordering by price on Sale page #8210

Merged
merged 1 commit into from Aug 25, 2017

Conversation

Projects
None yet
6 participants
@jocel1
Contributor

jocel1 commented Aug 1, 2017

Questions Answers
Branch? 1.7.2.x
Description? Performances & bugfix : product list is not limited on sales page when ordering by price
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket http://forge.prestashop.com/browse/BOOM-3698
How to test? Display the sale page & order by price
@jocel1

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Fabulous

wind face

@aleeks aleeks added this to the 1.7.2.2 milestone Aug 10, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Aug 23, 2017

Thank you @jocel1

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Aug 24, 2017

Contributor

Hi guys !

Does that PR fix also this ticket ?
http://forge.prestashop.com/browse/BOOM-2409

Thanks !

Contributor

vincentbz commented Aug 24, 2017

Hi guys !

Does that PR fix also this ticket ?
http://forge.prestashop.com/browse/BOOM-2409

Thanks !

@jocel1

This comment has been minimized.

Show comment
Hide comment
@jocel1

jocel1 Aug 24, 2017

Contributor

Hi @vincentbz!

I think it a different bug, this one only applies to the sale page

Contributor

jocel1 commented Aug 24, 2017

Hi @vincentbz!

I think it a different bug, this one only applies to the sale page

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Aug 25, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Aug 25, 2017

Thank you @jocel1

@eternoendless eternoendless merged commit 97e566b into PrestaShop:1.7.2.x Aug 25, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless changed the title from CO: Fix missing product limit/offset when ordering by price on Sale page to Fix missing product limit/offset when ordering by price on Sale page Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment