Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PS_GUEST_CHECKOUT_ENABLED ... only in checkout #8225

Merged

Conversation

@Quetzacoalt91
Copy link
Member

commented Aug 7, 2017

Questions Answers
Branch? develop
Description?

While trying to find the actual fix for #8195, we discovered a configuration value created especially for the checkout process but used on the whole front office. $guestAllowed is an attribute of the class FrontController, stating if a guest is allowed to reach a controller.
This variable was giving access to all pages once the checkout process started as a guest, and @maximebiloe fixed this issue with #5608.

But it brought another issue ... The guest was then refused on all controllers requiring an authentication, even if the value of $guestAllowed was true (as described in http://forge.prestashop.com/browse/BOOM-2057).

Type? bug fix
Category? FO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? http://forge.prestashop.com/browse/BOOM-2057
How to test? The checkout must be available for guests & logged customer. When you started the checkout process as a guest, try to reach ?controller=my-account. You must have a login form.

@vincentbz vincentbz added this to the 1.7.3.0 milestone Aug 7, 2017

@vincentbz

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2017

Tested and ok, thanks !

If I am a guest, I can't access that controller. I'm redirected to the login form

image

@prestonBot prestonBot added the QA ✔️ label Aug 8, 2017

@aleeks

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2017

Thank you @Quetzacoalt91

@aleeks aleeks merged commit d52806e into PrestaShop:develop Aug 9, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.