New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in AdminCartRulesController when limiting the validity … #8232

Merged
merged 2 commits into from Sep 22, 2017

Conversation

Projects
None yet
6 participants
@christianverardi
Contributor

christianverardi commented Aug 8, 2017

Questions Answers
Branch? 1.7.2.x
Description? Fixed bug in AdminCartRulesController when limiting the validity of a CartRule for a specific Customer in Multishop context. If you have a PrestaShop installation configured with more than one shop that does not share customers and you try to create a new CartRule for a specific shop and you look for a specific customer by typing its name inside the input, you will see results coming from all the shops. This solution filters the results based on the SHARE CUSTOMERS option.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? 1. Log-in the Back-office and enable the Multishop feature
2. create a new Shop in the same Shop Group
3. disable the Share Customers option on the Shop Group
4. create two customers with similar names or e-mails (one per shop)
5. select a specific shop
6. create a new CartRule and limit its validity on a specific customer by start typing the customer name.
7. You should see the results for the specific shop you are creating the cart rule for.

@vincentbz vincentbz added this to the 1.7.2.2 milestone Aug 8, 2017

@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Aug 8, 2017

Contributor

Hi @christianverardi ,

Thanks for that PR. We need to review and test it but that's an important fix, right :)

Contributor

vincentbz commented Aug 8, 2017

Hi @christianverardi ,

Thanks for that PR. We need to review and test it but that's an important fix, right :)

@eternoendless eternoendless modified the milestones: 1.7.2.3, 1.7.2.2 Aug 25, 2017

@eternoendless eternoendless changed the title from CO: Fixed bug in AdminCartRulesController when limiting the validity … to Fixed bug in AdminCartRulesController when limiting the validity … Sep 21, 2017

@eternoendless eternoendless changed the base branch from develop to 1.7.2.x Sep 21, 2017

CO: Fixed bug in AdminCartRulesController when limiting the validity …
…of a CartRule for a specific Customer in Multishop context
@tomlev

tomlev approved these changes Sep 22, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Sep 22, 2017

Thank you @christianverardi

@eternoendless eternoendless merged commit c551938 into PrestaShop:1.7.2.x Sep 22, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prestonBot prestonBot referenced this pull request Sep 23, 2017

Closed

1.7.2.x #8363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment