New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong final combination price if BC Math is not available #8238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eternoendless
commented
Aug 10, 2017
•
edited
edited
Questions | Answers |
---|---|
Branch? | 1.7.2.x |
Description? | The Adapter\Tools class had a buggy polyfill that replaced bcadd in case the BC Math library was not available. This fix uses replaces that with a new Decimal library that implements arbitrary decimal precision arithmetic operations whenever BC Math is not available. |
Type? | bug fix |
Category? | BO |
BC breaks? | No |
Deprecations? | Adapter\Tools::bcadd is now deprecated |
Fixed ticket? | http://forge.prestashop.com/browse/BOOM-3285 |
How to test? | See the ticket. In order to test without BC Math you need to either recompile your PHP or comment out lines 44-46 in vendor/prestashop/decimal/src/Operation/Addition.php |
tests/Unit/Adapter/ToolsTest.php
Outdated
|
||
public function provideTestCasesForBcAdd() | ||
{ | ||
return [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[]
=> array()
😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I did this before we settled that issue. I'll fix that.
FYI tests will fail until
|
Quetzacoalt91
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.