New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong final combination price if BC Math is not available #8238

Merged
merged 7 commits into from Aug 25, 2017

Conversation

Projects
None yet
4 participants
@eternoendless
Member

eternoendless commented Aug 10, 2017

Questions Answers
Branch? 1.7.2.x
Description? The Adapter\Tools class had a buggy polyfill that replaced bcadd in case the BC Math library was not available. This fix uses replaces that with a new Decimal library that implements arbitrary decimal precision arithmetic operations whenever BC Math is not available.
Type? bug fix
Category? BO
BC breaks? No
Deprecations? Adapter\Tools::bcadd is now deprecated
Fixed ticket? http://forge.prestashop.com/browse/BOOM-3285
How to test? See the ticket. In order to test without BC Math you need to either recompile your PHP or comment out lines 44-46 in vendor/prestashop/decimal/src/Operation/Addition.php

@eternoendless eternoendless changed the base branch from develop to 1.7.2.x Aug 10, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Aug 14, 2017

Member

FYI tests will fail until

  • This PR has ben merged
  • and Decimal is updated via composer here.
Member

eternoendless commented Aug 14, 2017

FYI tests will fail until

  • This PR has ben merged
  • and Decimal is updated via composer here.

@vincentbz vincentbz added this to the 1.7.2.2 milestone Aug 21, 2017

@marionf marionf added the QA ✔️ label Aug 23, 2017

@eternoendless eternoendless merged commit 0790028 into PrestaShop:1.7.2.x Aug 25, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:BOOM-3285 branch Nov 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment