Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL fix: Add a library to composer.json file #8242

Merged
merged 2 commits into from Aug 11, 2017

Conversation

@ramtin2025
Copy link
Contributor

commented Aug 11, 2017

Questions Answers
Branch? rtl
Description? Fix rtl.js and add new library to generate RTL stylesheets
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? Select RTL language (e.g persian, arabic) in PrestaShop installer.

This PR contains:

  • Updated rtl.js file to fix error on RTL languages
  • Add "ipresta/localize-fixture" to composer.json

This change is Reviewable

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Aug 11, 2017

Hello ramtin2025!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@maximebiloe maximebiloe merged commit 93c5d05 into PrestaShop:rtl Aug 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maximebiloe

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2017

Thank you @ramtin2025

@Danoosh Danoosh deleted the iPresta:iprestaRtl2 branch Aug 11, 2017

@prestonBot prestonBot referenced this pull request Oct 24, 2017

@xBorderie xBorderie added this to the 1.7.3.0 milestone Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.