New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display "Generate RTL stylesheets" section #8249

Merged
merged 2 commits into from Sep 12, 2017

Conversation

Projects
None yet
8 participants
@ramtin2025
Contributor

ramtin2025 commented Aug 11, 2017

Questions Answers
Branch? "rtl"
Description? Display "Generate RTL stylesheets" section if there is at least one RTL language
Type? new feature
Category? BO
BC breaks? no
Deprecations? no
How to test? See the "themes and logo" section on BO

This PR contains:

  • Modified AdminThemesController.php and options.tpl
@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Aug 11, 2017

Collaborator

Hello ramtin2025!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Aug 11, 2017

Hello ramtin2025!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@AlexEven

This comment has been minimized.

Show comment
Hide comment
@AlexEven

AlexEven Aug 24, 2017

Contributor

Hello @ramtin2025

Thanks for this PR
A bit late, but here are some more specifications regarding this topic.
https://trello.com/c/ibl7fzct/82-add-option-to-generate-css-file-for-theme

Thank you!

Contributor

AlexEven commented Aug 24, 2017

Hello @ramtin2025

Thanks for this PR
A bit late, but here are some more specifications regarding this topic.
https://trello.com/c/ibl7fzct/82-add-option-to-generate-css-file-for-theme

Thank you!

@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Aug 29, 2017

Contributor

Hello @ramtin2025,

Did you check @AlexEven's mockups on the Trello card?
Is it ok for you?

Also, you still have commits that do not respect our standards. Can you update them, please?

Regards

Contributor

maximebiloe commented Aug 29, 2017

Hello @ramtin2025,

Did you check @AlexEven's mockups on the Trello card?
Is it ok for you?

Also, you still have commits that do not respect our standards. Can you update them, please?

Regards

@mehrshadz

This comment has been minimized.

Show comment
Hide comment
@mehrshadz

mehrshadz Aug 30, 2017

Contributor

Hello @maximebiloe

@ramtin2025 is on a vacation and he'll be back soon. Then we'll continue our PRs and update the non-standard ones.

Thanks

Contributor

mehrshadz commented Aug 30, 2017

Hello @maximebiloe

@ramtin2025 is on a vacation and he'll be back soon. Then we'll continue our PRs and update the non-standard ones.

Thanks

@mehrshadz

This comment has been minimized.

Show comment
Hide comment
@mehrshadz

mehrshadz Sep 7, 2017

Contributor

@maximebiloe @AlexEven
We've updated the PR. Please check it

cheers

Contributor

mehrshadz commented Sep 7, 2017

@maximebiloe @AlexEven
We've updated the PR. Please check it

cheers

@AlexEven

This comment has been minimized.

Show comment
Hide comment
@AlexEven

AlexEven Sep 7, 2017

Contributor

Thank you guys for the update! :)

Contributor

AlexEven commented Sep 7, 2017

Thank you guys for the update! :)

@maximebiloe

This comment has been minimized.

Show comment
Hide comment
@maximebiloe

maximebiloe Sep 8, 2017

Contributor

Hello @ramtin2025,

We had some issues with Travis for our tests. Would you mind rebasing your PR, please?

Thank you

Contributor

maximebiloe commented Sep 8, 2017

Hello @ramtin2025,

We had some issues with Travis for our tests. Would you mind rebasing your PR, please?

Thank you

@Danoosh

This comment has been minimized.

Show comment
Hide comment
@Danoosh

Danoosh Sep 8, 2017

Contributor

@maximebiloe Please check this again.

Contributor

Danoosh commented Sep 8, 2017

@maximebiloe Please check this again.

@AlexEven

This comment has been minimized.

Show comment
Hide comment
@AlexEven

AlexEven Sep 11, 2017

Contributor

Thank you @Danoosh!
We'll review this quickly to merge it.

Contributor

AlexEven commented Sep 11, 2017

Thank you @Danoosh!
We'll review this quickly to merge it.

@toutantic toutantic merged commit b8d9645 into PrestaShop:rtl Sep 12, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@prestonBot prestonBot referenced this pull request Oct 24, 2017

Merged

RTL #8437

@xBorderie xBorderie added this to the 1.7.3.0 milestone Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment