New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error while reaching AdminModules #8266

Merged
merged 1 commit into from Aug 23, 2017

Conversation

Projects
None yet
3 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 22, 2017

Questions Answers
Branch? 1.7.2.x
Description? When we want to be redirected to the module page after login, we have to use the old controller AdminModules. Unfortunately, with #8141, the core was trying to load data from a unspecified module name, throwing a fatal error.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Try to login with the redirect to the module page (Your URL must be like this: http://<shop_url>/admin-dev/index.php?controller=AdminLogin&redirect=AdminModules. With this PR, you should not have fatal errors anymore

@aleeks aleeks added this to the 1.7.2.2 milestone Aug 23, 2017

@aleeks

aleeks approved these changes Aug 23, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Aug 23, 2017

Thank you @Quetzacoalt91

@eternoendless eternoendless merged commit f22da24 into PrestaShop:1.7.2.x Aug 23, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment