New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Postal Code of South Korea #8273

Merged
merged 1 commit into from Nov 22, 2017

Conversation

Projects
None yet
4 participants
@hibatallahAouadni
Contributor

hibatallahAouadni commented Aug 24, 2017

Questions Answers
Branch? 1.6.1.x
Description? the zip code of South Korea get changed since August 1, 2015 and we didn't update it since 2011.
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-7638
How to test? After install, access to BO->Localization->Countries, then click on "edit" button of South Korea, you will see the zip code format is "NNNNN" (and not the old format "NNN-NNN"). FO, try to add a new adress in South Korea, set 11230 as zip code (the zip code of Gangnam city). The field will be validated.

This change is Reviewable

@hibatallahAouadni

This comment has been minimized.

Show comment
Hide comment
@hibatallahAouadni

hibatallahAouadni Sep 29, 2017

Contributor

@vincentbz @eternoendless milestone please 1.6.1.18

Contributor

hibatallahAouadni commented Sep 29, 2017

@vincentbz @eternoendless milestone please 1.6.1.18

@eternoendless eternoendless added this to the 1.6.1.18 milestone Sep 29, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit 622dbc9 into PrestaShop:1.6.1.x Nov 22, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment