New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow the negative discounts in orders #8274

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
5 participants
@hibatallahAouadni
Contributor

hibatallahAouadni commented Aug 25, 2017

Questions Answers
Branch? 1.6.1.x
Description? add a test on "discount_value" field, if it's empty or negative then an error will be displayed
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-7932
How to test? BO, create an order. Then, try to add a negative discount (for exemple "-2" as amount). An error will be displayed.

order idtvzulbq


This change is Reviewable

@hibatallahAouadni

This comment has been minimized.

Show comment
Hide comment
@hibatallahAouadni

hibatallahAouadni Sep 29, 2017

Contributor

@vincentbz @eternoendless milestone 1.6.1.18 please

Contributor

hibatallahAouadni commented Sep 29, 2017

@vincentbz @eternoendless milestone 1.6.1.18 please

@eternoendless eternoendless added this to the 1.6.1.18 milestone Sep 29, 2017

@jocel1

jocel1 approved these changes Nov 2, 2017

LGTM

@eternoendless eternoendless modified the milestones: 1.6.1.18, 1.6.1.19 Jan 29, 2018

@eternoendless eternoendless modified the milestones: 1.6.1.19, 1.6.1.20 May 24, 2018

@eternoendless eternoendless modified the milestones: 1.6.1.20, 1.6.1.21 Jun 27, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Sep 24, 2018

Thank you @hibatallahAouadni

@eternoendless eternoendless merged commit 4db399e into PrestaShop:1.6.1.x Sep 24, 2018

2 of 3 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment