New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context mocker for front controller tests #8298

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
5 participants
@tomlev
Member

tomlev commented Sep 1, 2017

Questions Answers
Branch? 1.7.2.x
Description? Context mock helper class for testing
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

Important guidelines

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Sep 1, 2017

Collaborator

Hello tomlev!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Sep 1, 2017

Hello tomlev!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@eternoendless eternoendless changed the title from TE: add context mocker for front controller tests to Add context mocker for front controller tests Sep 1, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 4, 2017

Member

The new class is defined but not used. It this PR still a work in progress?

Member

Quetzacoalt91 commented Sep 4, 2017

The new class is defined but not used. It this PR still a work in progress?

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Sep 4, 2017

Member

Actually it should be rebased into 1.7.2.x. I had @tomlev push it as a separate PR so that he could use elsewhere.

Member

eternoendless commented Sep 4, 2017

Actually it should be rebased into 1.7.2.x. I had @tomlev push it as a separate PR so that he could use elsewhere.

@Quetzacoalt91 Quetzacoalt91 changed the base branch from develop to 1.7.2.x Sep 4, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 4, 2017

Member

We are lucky, no need to rebase here.

Member

Quetzacoalt91 commented Sep 4, 2017

We are lucky, no need to rebase here.

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Sep 5, 2017

Member

Thank you @tomlev

Member

eternoendless commented Sep 5, 2017

Thank you @tomlev

@eternoendless eternoendless merged commit bfcf54f into PrestaShop:1.7.2.x Sep 5, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xBorderie xBorderie added this to the 1.7.2.3 milestone Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment