New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug js and css cache file name don't change #8307

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
8 participants
@prestarocket
Contributor

prestarocket commented Sep 5, 2017

Questions Answers
Branch? develop
Description? - CCC js/css must be enable
- clear cache in BO and bottom-***.js name for ex. don't change => browsers keep always the same file in cache and if you change custom.js for example, changes are not apply due to browser cache
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? - CCC js/css must be enable
- go to front and see js filename for ex. (bottom-***.js)
- got to admin perf, delete cache
- go to front : same file name
@prestarocket

This comment has been minimized.

Show comment
Hide comment
@prestarocket

prestarocket Sep 5, 2017

Contributor

i don t see any pb in my commit name...

Contributor

prestarocket commented Sep 5, 2017

i don t see any pb in my commit name...

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 5, 2017

Member

I guess this is because of the space between CO and : 🙂

Member

Quetzacoalt91 commented Sep 5, 2017

I guess this is because of the space between CO and : 🙂

@prestarocket

This comment has been minimized.

Show comment
Hide comment
@prestarocket

prestarocket Sep 5, 2017

Contributor

so it's ok ?

Contributor

prestarocket commented Sep 5, 2017

so it's ok ?

@prestarocket prestarocket changed the title from CO : fix bug js and css cache file name don't change to CO: fix bug js and css cache file name don't change Sep 5, 2017

@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Sep 5, 2017

Contributor

Could you edit out that space in the commit's name, rather that in the PR title?
Thank you!

Contributor

xBorderie commented Sep 5, 2017

Could you edit out that space in the commit's name, rather that in the PR title?
Thank you!

@aleeks

This comment has been minimized.

Show comment
Hide comment
@aleeks

aleeks Sep 6, 2017

Contributor

Code looks ok

Contributor

aleeks commented Sep 6, 2017

Code looks ok

@aleeks aleeks added the Code ✔️ label Sep 6, 2017

@vincentbz vincentbz added this to the 1.7.3.0 milestone Sep 7, 2017

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Oct 6, 2017

Contributor

Hello @prestarocket
I would like to test your PR but I can not reproduce the issue.
Can I try with any .js file ? Do I have to rename the file or change the content ?
If you can give me more details to reproduce the issue, it will help.
Thanks !

Contributor

marionf commented Oct 6, 2017

Hello @prestarocket
I would like to test your PR but I can not reproduce the issue.
Can I try with any .js file ? Do I have to rename the file or change the content ?
If you can give me more details to reproduce the issue, it will help.
Thanks !

CO: fix bug js and css cache name don t change
- CCC js/css must be enable
- clear cache in BO and bottom-***.js name for ex. don't change => browsers keep always the same file in cache and if you change custom.js for example, changes are not apply due to browser cache

@eternoendless eternoendless changed the title from CO: fix bug js and css cache file name don't change to Fix bug js and css cache file name don't change Oct 9, 2017

@marionf marionf added QA ✔️ and removed waiting for author labels Oct 9, 2017

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Oct 9, 2017

Thank you @prestarocket

@eternoendless eternoendless merged commit 6ed088a into PrestaShop:develop Oct 9, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment