New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Module configure permission #8321

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
7 participants
@hibatallahAouadni
Contributor

hibatallahAouadni commented Sep 8, 2017

Questions Answers
Branch? 1.6.1.x
Description? There is a separate "Configure" permission for every module in the back office, but configure permission need to module edit permission, after giving module edit permission user can disable and uninstall the module also, that should not happen.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/PSCSX-5940
How to test? Just try to give a module to only Configure permission not to disable and uninstall the module permission. You can see the issue.

This change is Reviewable

@xBorderie xBorderie added this to the 1.6.1.18 milestone Sep 8, 2017

@eternoendless eternoendless modified the milestones: 1.6.1.18, 1.6.1.19 Jan 29, 2018

@eternoendless eternoendless modified the milestones: 1.6.1.19, 1.6.1.20 May 24, 2018

@eternoendless eternoendless modified the milestones: 1.6.1.20, 1.6.1.21 Jun 27, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Sep 24, 2018

Thank you @hibatallahAouadni

@eternoendless eternoendless merged commit 3743ad2 into PrestaShop:1.6.1.x Sep 24, 2018

2 of 3 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment