New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array-check in additional form fields from modules #8339

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
5 participants
@AntoInta
Contributor

AntoInta commented Sep 15, 2017

It could happen that some modules does not have a correct list of additional form fields, i.e. they return an empty string.
This patch ensures that fields list is, at least, an array.

Questions Answers
Branch? develop
Description? PS 1.7.2.2
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? Create a simple module listening hook "additionalCustomerFormFields", return an empty string in this module. Some Prestashop Addons modules, i.e. multiblocks, causes an exception in the Form because of they don't have correct fields.
@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Sep 15, 2017

Collaborator

Hello AntoInta!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Sep 15, 2017

Hello AntoInta!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@AntoInta AntoInta changed the title from Array-check in additional form fields from modules to CO: Array-check in additional form fields from modules Sep 15, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 17, 2017

CO: Array-check in additional form fields from modules
It could happen that some modules does not have a correct list of additional form fields, i.e. they return an empty string.
This patch ensures that fields list is, at least, an array.
@Quetzacoalt91

PR updated to follow commit standards

@Quetzacoalt91 Quetzacoalt91 changed the title from CO: Array-check in additional form fields from modules to Array-check in additional form fields from modules Sep 18, 2017

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 18, 2017

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Sep 18, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- classes/form/CustomerFormatter.php  1
         

See the complete overview on Codacy

codacy-bot commented Sep 18, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- classes/form/CustomerFormatter.php  1
         

See the complete overview on Codacy

@Quetzacoalt91 Quetzacoalt91 merged commit 4e19168 into PrestaShop:develop Sep 18, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 18, 2017

Thank you @AntoInta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment