New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the currency display in supply order #8346

Merged
merged 1 commit into from Sep 22, 2017

Conversation

Projects
None yet
5 participants
@hibatallahAouadni
Contributor

hibatallahAouadni commented Sep 18, 2017

Questions Answers
Branch? 1.7.2.x
Description? The currency wasn't called in "displayPrice" and that's why the default currency used to be displayed instead of the chosen one, while creating the supply order. So, I made a test, if the currency exists then I display it.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-3760
How to test? Let's choose "euro" as the default currency. Then, try to create a new Supply order and choose "dollar" as a currency, save it. Back to the supply orders list, click on the new created to view the details. You will see the "dollar" is displayed as a currency and not the "euro", OK.
@vincentbz

This comment has been minimized.

Show comment
Hide comment
@vincentbz

vincentbz Sep 18, 2017

Contributor

Hi !

Thanks for that PR. As there is no stock management like in 1.6 in the 1.7 version, do you know where this helper is also used to see if it's ok ?

Contributor

vincentbz commented Sep 18, 2017

Hi !

Thanks for that PR. As there is no stock management like in 1.6 in the 1.7 version, do you know where this helper is also used to see if it's ok ?

@eternoendless eternoendless added this to the 1.7.2.3 milestone Sep 18, 2017

@hibatallahAouadni

This comment has been minimized.

Show comment
Hide comment
@hibatallahAouadni

hibatallahAouadni Sep 18, 2017

Contributor

Hello @vincentbz
this helper is used to display carts list and currencies list.

Contributor

hibatallahAouadni commented Sep 18, 2017

Hello @vincentbz
this helper is used to display carts list and currencies list.

@Quetzacoalt91 Quetzacoalt91 merged commit 21131a5 into PrestaShop:1.7.2.x Sep 22, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 22, 2017

Thank you @hibatallahAouadni

@prestonBot prestonBot referenced this pull request Sep 23, 2017

Closed

1.7.2.x #8363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment