New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods to check in which context module is executed #8347

Merged
merged 1 commit into from Sep 19, 2017

Conversation

Projects
None yet
4 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Sep 19, 2017

Questions Answers
Branch? develop
Description? In Back office modules, we can be in admin legacy context (old pages) or in Symfony context (new pages), but as a modules developer we have no way to know in which context we are. This contribution solves this issue.
Type? new feature
Category? CO
BC breaks? no
Deprecations? no
How to test? You need to create a module and execute a hook available in both legacy and new pages (displayBackOfficeHeader for instance) and return differents values :)

Important guidelines


This change is Reviewable

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Sep 19, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- classes/module/Module.php  2
         

See the complete overview on Codacy

codacy-bot commented Sep 19, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- classes/module/Module.php  2
         

See the complete overview on Codacy

@PrestaShop PrestaShop deleted a comment from codacy-bot Sep 19, 2017

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 19, 2017

Contributor

Thanks for review @Quetzacoalt91 !

Contributor

mickaelandrieu commented Sep 19, 2017

Thanks for review @Quetzacoalt91 !

@mickaelandrieu mickaelandrieu merged commit 504fbaa into PrestaShop:develop Sep 19, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:bogoss/distinct-legacy-from-sf-env branch Sep 19, 2017

@xBorderie xBorderie added this to the 1.7.3.0 milestone Sep 20, 2017

@eternoendless eternoendless changed the title from MO: added methods to check in which context module is executed to Added methods to check in which context module is executed Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment