New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id_product_attribute to productLink #8351

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
5 participants
@prestamodule
Contributor

prestamodule commented Sep 20, 2017

Questions Answers
Branch? develop
Description? As now, while you check a product with combinations, the product link inside the breadcrumb do not get the selected attribute and the click on it will make a canonical redirection.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? With debug mode on, you can click on the breadcrumb link while a product has combinations. Fetch this PR and do the same. No canonical redirection will be done.

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 26, 2017

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.3.0 milestone Oct 2, 2017

@Quetzacoalt91 Quetzacoalt91 merged commit 52c4c64 into PrestaShop:develop Oct 2, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Oct 2, 2017

Thank you @prestamodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment