New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix already defined class during upgrade process from 1.6 to 1.7 #8352

Merged
merged 1 commit into from Sep 20, 2017

Conversation

Projects
None yet
3 participants
@kpodemski
Contributor

kpodemski commented Sep 20, 2017

Solved error:
Cannot use PrestaShopBundle\Service\Database\Upgrade as Upgrade because the name is already in use

Questions Answers
Branch? develop
Description? couldn't update 1.6 to 1.7 without this change
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? try to update 1.6.1.17 to 1.7
CO: fix upgrade process from 1.6 to 1.7
Solved error:
Cannot use PrestaShopBundle\Service\Database\Upgrade as Upgrade because the name is already in use

@Quetzacoalt91 Quetzacoalt91 merged commit 44e907b into PrestaShop:develop Sep 20, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 20, 2017

Thank you @kpodemski

@Quetzacoalt91 Quetzacoalt91 changed the title from CO: fix upgrade process from 1.6 to 1.7 to Fix already defined class during upgrade process from 1.6 to 1.7 Sep 20, 2017

@xBorderie xBorderie added this to the 1.7.3.0 milestone Sep 20, 2017

@xBorderie

This comment has been minimized.

Show comment
Hide comment
@xBorderie

xBorderie Sep 20, 2017

Contributor

Cool, thanks Krystian!
Wouldn't that also be useful in 1.7.2.x for the forthcoming 1.7.2.3, while waiting for 1.7.3.0? @Quetzacoalt91

Contributor

xBorderie commented Sep 20, 2017

Cool, thanks Krystian!
Wouldn't that also be useful in 1.7.2.x for the forthcoming 1.7.2.3, while waiting for 1.7.3.0? @Quetzacoalt91

@kpodemski

This comment has been minimized.

Show comment
Hide comment
@kpodemski

kpodemski Sep 20, 2017

Contributor

@xBorderie i don't know, upgrader doesn't allow to update to 1.7.2.2 etc. only to 1.7.2.0 1.7.3.0 so i don't think we need that for a path version

Contributor

kpodemski commented Sep 20, 2017

@xBorderie i don't know, upgrader doesn't allow to update to 1.7.2.2 etc. only to 1.7.2.0 1.7.3.0 so i don't think we need that for a path version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment