New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product pages tabs #8355

Merged
merged 3 commits into from Sep 21, 2017

Conversation

Projects
None yet
4 participants
@nihco2
Contributor

nihco2 commented Sep 20, 2017

Questions Answers
Branch? develop
Description? Fix product page tabs behavior after bootstrap update
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-3812
How to test? Click on product page tabs

@nihco2 nihco2 changed the title from BO: Fix product pages tabs to Fix product pages tabs Sep 20, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 20, 2017

Member

Does it require a npm update somewhere?

Member

Quetzacoalt91 commented Sep 20, 2017

Does it require a npm update somewhere?

@nihco2

This comment has been minimized.

Show comment
Hide comment
@nihco2
Contributor

nihco2 commented Sep 21, 2017

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 21, 2017

Member

I still have an issue when switching to another tab then going back to the first one, as you can see:
capture du 2017-09-21 14-42-23

The textarea disapperead under "description"

Member

Quetzacoalt91 commented Sep 21, 2017

I still have an issue when switching to another tab then going back to the first one, as you can see:
capture du 2017-09-21 14-42-23

The textarea disapperead under "description"

nihco2
nihco2
@nihco2

This comment has been minimized.

Show comment
Hide comment
@nihco2

nihco2 Sep 21, 2017

Contributor

@Quetzacoalt91 fixed !

Contributor

nihco2 commented Sep 21, 2017

@Quetzacoalt91 fixed !

@Quetzacoalt91 Quetzacoalt91 merged commit 63278ca into PrestaShop:develop Sep 21, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 21, 2017

Thank you @nihco2

@xBorderie xBorderie added this to the 1.7.3.0 milestone Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment