New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved syntax check file tests output #8356

Merged
merged 1 commit into from Sep 21, 2017

Conversation

Projects
None yet
3 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Sep 20, 2017

Questions Answers
Branch? develop
Description? add visual information that check file tests have failed, it's useful only for PHP checks as Yaml and Twig linting is already throwing a meaning full exception.
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? execute bash ./tests/check_file_syntax.sh

checknok
checkok

@mickaelandrieu mickaelandrieu changed the title from TE: improve Syntax check file tests output to Improved syntax check file tests output Sep 20, 2017

exit 0;
else
echo -e "\e[91mSYNTAX TESTS FAILED"

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Sep 20, 2017

Member

WHY ARE YOU YELLING?!?

@Quetzacoalt91

Quetzacoalt91 Sep 20, 2017

Member

WHY ARE YOU YELLING?!?

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Sep 21, 2017

Contributor

AHAHAHAHAH because tests failed ;'(

@mickaelandrieu

mickaelandrieu Sep 21, 2017

Contributor

AHAHAHAHAH because tests failed ;'(

@mickaelandrieu mickaelandrieu merged commit daf6be4 into PrestaShop:develop Sep 21, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:bogoss/improve-syntax-check-tests branch Sep 21, 2017

@xBorderie xBorderie added this to the 1.7.3.0 milestone Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment